Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-7620 Fixed Test cases for MacOS build #6349

Open
wants to merge 1 commit into
base: Payara5
Choose a base branch
from

Conversation

rohan267
Copy link
Contributor

@rohan267 rohan267 commented Aug 1, 2023

(cherry picked from commit 559fc22)

JIRA: https://payara.atlassian.net/browse/FISH-7620 - Fixing Mac OS build

Description

At present, WatchService API takes around 10 seconds to update file system on Mac OS, so added delay of 10 seconds in case of assertion failure which fix Mac OS build. Have to ignore the assertion In a case where WatchService is failing to read the path pattern watcher-files.example

Testing

New tests

Fixed existing tests with appropriate delays in case of Mac OS

Testing Performed

Maven built succesfully

Testing Environment

Maven: 3.9.2
Java version: 11.0.18, vendor: Oracle Corporation
Default locale: en_IN, platform encoding: UTF-8
OS name: "mac os x", version: "13.4", arch: "aarch64", family: "mac"

@rohan267 rohan267 requested a review from pdudits August 1, 2023 09:27
@lprimak
Copy link
Contributor

lprimak commented Aug 3, 2023

jenkins test

1 similar comment
@lprimak
Copy link
Contributor

lprimak commented Aug 12, 2023

jenkins test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants