make glyphs use unicode symbols #506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most symbols now line up well. Some symbols are larger than the old symbols and may need to be scaled somehow, this is especially an issue with grace notes as the head and flag aren't scaled to the correct stem size. |
|
a few symbols I couldn't find are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a proof of concept at the moment. Although It does seem to work very well with just the initial change. All glyphs render okay other than a few minor changes to positioning.
It should eventually allow easier management of fonts and glyphs. for example:
a user should be able to load any smufl font via css and abcjs should use the loaded font for glyphs instead.
a new directive may need to be added to get abcjs to set the font family on the svg.
There are also a few scaling issues.
font-size: xx-largeneeds to be used to scale the font to match the current rendering set up. This might just need theabc_spacingfile modified to render things at the correct size in relation to the font.