Adding more granular Set/Map acceptance tests and replacements #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to preserve as much of the original implementation as possible. Relates to paulmillr#326.
|
This passes in Firefox 4/5/6/10/14/18/20/23/24/25/36, Firefox Nightly 40.0a1 2015-04-07 + 2015-04-08, Safari 5/5.1/6/6.1/7/8, Chrome 14/20/25/30/35/41/44, IE 9/10/11, Opera 12 (1 pre-existing failure)/17/20/27. I'll update this comment as I test more browsers - please help me test :-) |
ljharb
force-pushed
the
map_set_preserve_native
branch
3 times, most recently
from
592477c
to
427f9ff
Compare
ljharb
force-pushed
the
map_set_preserve_native
branch
2 times, most recently
from
dd1c620
to
a629e53
Compare
ljharb
added a commit
that referenced
this pull request
Apr 9, 2015
Adding more granular Set/Map acceptance tests and replacements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding much more granular Set/Map acceptance tests and replacements, to preserve as much of the original implementation as possible.
Relates to #326.