Add --file option. #170
Open
Add --file option. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-open
Outdated
| @@ -49,6 +52,11 @@ IFS='=' read -ra suffix_flag <<< "$suffix_flag" | |||
| function join_by { local IFS="$1"; shift; echo "$*"; } | |||
| suffix=$(join_by "=" "${suffix_flag[@]:1}") | |||
|
|
|||
| # parse file from file=value | |||
| IFS='=' read -ra file_flag <<< "$file_flag" | |||
| function join_by { local IFS="$1"; shift; echo "$*"; } | |||
There was a problem hiding this comment.
Why are you redefining this?
There was a problem hiding this comment.
The join_by function definition was cut and pasted, and could probably be removed.
|
Does anyone care about this? It's been open for almost 2 months, with only a trivial (and addressed) comment. |
|
It would be nice to have. |
|
+1 for this request, I'm currently using the feature branch in place of |
|
Would it be better to have a more general |
|
Does this open the file in the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a --file option, allowing
git open --file <path>, where<path>is a path within the repository, and can either be a file or directory.This is similar to what was requested years ago in #54, but isn't automatic. Presumably it could be made automatic, if someone more familiar with git internals and better at writing shell scripts than me wanted it to be.