Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 260 #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed issue 260 #262

wants to merge 1 commit into from

Conversation

superhit0
Copy link
Collaborator

@patw0929 @nutboltu

  • Added new proptype formatFull

will be adding tests too...

putting DNM for now.

Please have a look at the logic

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.058% when pulling 90c212f on superhit0:issue-260 into 6c8ce61 on patw0929:master.

@patw0929
Copy link
Owner

patw0929 commented Jan 9, 2019

Thanks for the PR!

Is this prop using for displaying the value as formatted number with country code?
Even if I use nationalMode (true is default), right?


Wait a minute, I found there is an issue with this code:

        <IntlTelInput
          onPhoneNumberChange={this.changePhone3}
          onPhoneNumberBlur={this.blurHandler3}
          onSelectFlag={this.selectFlagHandler3}
          defaultCountry="auto"
          value={this.state.phoneNumber3}
          geoIpLookup={lookup}
          css={['intl-tel-input', 'form-control']}
        />


And please help to update index.html for this new prop. :)

@superhit0
Copy link
Collaborator Author

cool thanks for pointing it out, will have a look.

@superhit0
Copy link
Collaborator Author

superhit0 commented Jan 13, 2019

@patw0929

        <IntlTelInput
          onPhoneNumberChange={this.changePhone3}
          onPhoneNumberBlur={this.blurHandler3}
          onSelectFlag={this.selectFlagHandler3}
          defaultCountry="auto"
          value={this.state.phoneNumber3}
          geoIpLookup={lookup}
          css={['intl-tel-input', 'form-control']}
        />

I dont see format prop here, why formattting is happening?

@m-nathani
Copy link

m-nathani commented Jan 29, 2020

Thanks for the PR!

Is this prop using for displaying the value as formatted number with country code?
Even if I use nationalMode (true is default), right?

Wait a minute, I found there is an issue with this code:

        <IntlTelInput
          onPhoneNumberChange={this.changePhone3}
          onPhoneNumberBlur={this.blurHandler3}
          onSelectFlag={this.selectFlagHandler3}
          defaultCountry="auto"
          value={this.state.phoneNumber3}
          geoIpLookup={lookup}
          css={['intl-tel-input', 'form-control']}
        />

And please help to update index.html for this new prop. :)

Hi guys did found out how to resolve this issue ? i am still facing the this issue of currsor moving at wrong place @superhit0 @patw0929 ?

@nutboltu
Copy link
Collaborator

@m-nathani Sorry I am in immense workload. Do you mind if I take a look in the weekend. By this time, can you please fix the merge conflict?

@m-nathani
Copy link

@m-nathani Sorry I am in immense workload. Do you mind if I take a look in the weekend. By this time, can you please fix the merge conflict?

dont have the write access, but looking forward for the fix.. currently stuck on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants