Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared jQuery references instead of repeately querying DOM #101

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tommcc
Copy link
Contributor

@tommcc tommcc commented Oct 30, 2017

This change aims to improve readability and efficiency by reducing repeated DOM and/or jQuery selectors I found in styleguide.js.

  • Make more use of an existing reference, $sgIframe
  • Create two new references, $sgIframeContainer and $sgViewportCover and replace queries with them.

In cases where an instance of the repeated query was a jQuery selector, simply use the earlier-defined jQuery reference. In cases where a native document.querySelector() is used, I call jQuery's .get(0), which pulls out the native DOM element from the reference. In either case, the DOM shouldn't have to be searched again for the same elements over and over.

I particularly focused on making these replacements in connection with the mousemove event while dragging the iframe handle, which can potentially be triggered many times per second.

@bradfrost
Copy link
Member

Hey @tommcc! Thanks so much for helping clean up the JavaScript files. This is fantastic work that cleans things up nicely.

Eye-balling it looks good from my end, but I'd need some help from @bmuenzenmeyer or somebody to help me pull it down and test things for real. I'm a bit clumsy in that department.

@bmuenzenmeyer bmuenzenmeyer self-requested a review November 6, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants