Changes for Microsoft Visual C++ compiler (2022) compatibility #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved functions to SystemUtil.cpp to not include windows.h in other c++ files (preprocessor names collide) - replaced pragmas pack(1)...pack(0) with pack(push, 1)...pack(pop) (pack(0) does not reset the alignment) - variabe-length arrays are not supported - _USE_MATH_DEFINES must be set before cmath inclusion to get macros like M_PI, M_PI_2, ... - Tests: SDL requires "int main(int argc, char * argv[])" instead of "int main(int argc, const char * argv[])" Right now all programs are running, but GUI elements (like checkboxes) do not show text
|
I added a PR to Microsoft's STL implementation because it doesn't allow zero sigma in normal_distribution (microsoft/STL#3596). If this will be rejected: Is it possible to use a very small sigma value where it is needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now all programs are running, but GUI elements (like checkboxes) do not show text