Base.encode64 and url_encode64 do not accept :case as a valid option #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR results from an error raised by Dialyzer, when using
SecureRandom.base64()
orSecureRandom.urlsafe_base64()
in a functionfoo/0
:While digging further, it turns out that Dialyzer raises because
Base.encode64()
andBase.url_encode64()
do not support a:case
option:See the recent elixir docs: https://hexdocs.pm/elixir/Base.html#url_encode64/2 & https://hexdocs.pm/elixir/Base.html#encode64/2.
I'm not sure if the option ever made sense (or why Dialyzer didn't raise this ealier in my project 🤷♀️) - but I hope the PR will at least help other peeps running into this issue, as the original Dialyzer error is cryptic 🥸.