New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Do not mock ParseObject and ParseOp for ParseQuery tests #2123
Conversation
Thanks for opening this pull request! |
I will reformat the title to use the proper commit message syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2123 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 61 64 +3
Lines 6185 6275 +90
Branches 1499 1506 +7
===========================================
+ Hits 6184 6275 +91
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This change has been released in version 5.1.0-alpha.10 |
🎉 This change has been released in version 5.1.0-beta.1 |
🎉 This change has been released in version 5.1.0 |
Pull Request
Issue
#2122
Closes: #2122
Approach
ParseQuery tests: Do not mock ParseObject and ParseOp
ParseObject mocks used by the ParseQuery tests on the upstream branch are broken, and the LocalDatastore tests are only passing because the ParseQuery tests before them are unmocking
ParseObject
.Tasks
None