Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error code for email already verified #1438

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

pash2048
Copy link

@pash2048 pash2048 commented Dec 23, 2021

See parse-community/parse-server##7740

New Pull Request Checklist

Issue Description

This PR adds a new error code when users requestEmailVerification for verified email, now the parse server sends the OTHER_CAUSE error code and it needs a better error code instead of -1 and should have a message instead of stack property.

Related issue:
parse-community/parse-server##7740

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 23, 2021

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@pash2048 pash2048 changed the title Added an error code for email already verified feature: added an error code for email already verified Dec 23, 2021
@pash2048 pash2048 force-pushed the new-error-code-for-emailed-verified branch from 0a5b63b to b143807 Compare December 23, 2021 10:36
@pash2048 pash2048 changed the title feature: added an error code for email already verified feat: added an error code for email already verified Dec 23, 2021
@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Dec 24, 2021
@parse-github-assistant
Copy link

The label type:feature cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the type:feature New feature or improvement of existing feature label Dec 24, 2021
src/ParseError.js Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title feat: added an error code for email already verified feat: add error code for email already verified Dec 24, 2021
@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (alpha@d084ac9). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8653fd4 differs from pull request most recent head f39a040. Consider uploading reports for the commit f39a040 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##             alpha    #1438   +/-   ##
========================================
  Coverage         ?   99.94%           
========================================
  Files            ?       61           
  Lines            ?     5949           
  Branches         ?     1354           
========================================
  Hits             ?     5946           
  Misses           ?        3           
  Partials         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d084ac9...f39a040. Read the comment docs.

@pash2048 pash2048 force-pushed the new-error-code-for-emailed-verified branch from b143807 to 8653fd4 Compare December 24, 2021 09:00
* @static
*/
ParseError.EMAIL_ALREADY_VERIFIED = 212;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the 2nd empty line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for being late. I removed 2nd empty line and push agin.
please check

@pash2048 pash2048 force-pushed the new-error-code-for-emailed-verified branch from 8653fd4 to f39a040 Compare February 6, 2022 09:22
@pash2048 pash2048 requested a review from mtrezza February 6, 2022 09:24
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Since this depends on a PR in Parse Server for parse-community/parse-server#7740, we'll wait with merging until a PR has been submitted there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants