Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalDatastore tests fail #2122

Closed
4 tasks done
mstniy opened this issue May 10, 2024 · 4 comments · Fixed by #2123
Closed
4 tasks done

LocalDatastore tests fail #2122

mstniy opened this issue May 10, 2024 · 4 comments · Fixed by #2123
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:ci CI related issue

Comments

@mstniy
Copy link
Contributor

mstniy commented May 10, 2024

New Issue Checklist

Issue Description

ParseQuery LocalDatastore tests fail when run in isolation.
They pass when run together with the rest of the ParseQuery tests.
They fail when the ParseQuery test that call jest.dontMock('../ParseObject'); are all disabled, strong evidence that the mocks are broken and the tests only pass in the CI pipeline because the rest of the ParseObjects tests (which run before the localdatastore tests) undo them.

Steps to reproduce

  • Open latest alpha (aff0a00) in VSCode
  • npm install
  • Run only the tests for ParseQuery LocalDatastore

Actual Outcome

The following tests fail:

  • can query offline
  • can query offline with localId
  • can query offline sort multiple
  • can query offline select keys

Expected Outcome

  • The tests should pass, even when run in isolation.

Environment

Server

  • Parse Server version: irrelevant
  • Operating system: Ubuntu 22.04
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Database

  • System (MongoDB or Postgres): irrelevant
  • Database version: irrelevant
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): irrelevant

Client

  • Parse JS SDK version: aff0a00a6f5d507166dbfc14d1b695002399913b

Logs

Copy link

parse-github-assistant bot commented May 10, 2024

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.10

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 15, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:ci CI related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants