Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update setup instructions in README for current Android Studio #1198

Merged
merged 4 commits into from
May 25, 2023

Conversation

edgarwideman
Copy link
Contributor

@edgarwideman edgarwideman commented May 24, 2023

Issue Description

The Getting Started instruction in the README file were out of date for the current versions of Android Studio. For newer Android Studio projects created in Android Studio Bumblebee | 2021.1.1 or newer, the JitPack repository needs to be added into the root level file settings.gradle instead of build.gradle.

Closes: #1197

Approach

Edited the README.md file to reflect current steps required to setup a new Android Studio project.

TODOs before merging

  • Add tests (no need)
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 24, 2023

Thanks for opening this pull request!

@edgarwideman edgarwideman changed the title Updated readme for current android studio setup docs: Updated readme for current android studio setup May 24, 2023
README.md Show resolved Hide resolved
@edgarwideman edgarwideman requested a review from mtrezza May 24, 2023 14:43
@mtrezza mtrezza changed the title docs: Updated readme for current android studio setup docs: Update setup instructions in README for current Android Studio May 24, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you take a final look, I did some refactoring.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ebd443) 0.00% compared to head (e77b53e) 0.00%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1198   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         122     122           
  Lines        9971    9971           
  Branches     1345    1345           
======================================
  Misses       9971    9971           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edgarwideman
Copy link
Contributor Author

edgarwideman commented May 24, 2023

Looks good, I'd say go ahead and merge if it's good with you.

@mtrezza mtrezza merged commit f9843c5 into parse-community:master May 25, 2023
7 checks passed
@parseplatformorg
Copy link

🎉 This change has been released in version 4.2.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README Getting Started guide is out of date
3 participants