Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Nacon Pro Compact #229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for Nacon Pro Compact #229

wants to merge 2 commits into from

Conversation

guegse
Copy link

@guegse guegse commented Dec 25, 2022

No description provided.

@paroj
Copy link
Owner

paroj commented Jan 4, 2023

please check current master again. probably this is not needed any more

@guegse
Copy link
Author

guegse commented Jan 5, 2023

please check current master again. probably this is not needed any more

My 2 controllers have product ids 0x0616 and 0x0618 respectively so I think this PR is still needed for them to work:

$ lsusb
...
Bus 001 Device 007: ID 3285:0616 NACON Pro Compact
Bus 001 Device 006: ID 3285:0618 NACON Pro Compact

General (noob) questions regarding the structure of this driver:

/*
 * Xbox 360 has a vendor-specific class, so we cannot match it with only
 * USB_INTERFACE_INFO (also specifically refused by USB subsystem), so we
 * match against vendor id as well. Wired Xbox 360 devices have protocol 1,
 * wireless controllers have protocol 129.
 */

Does that mean that all vendor and product IDs have to be listed explicitly in the driver for it to work? Would it make sense to make an exception for this driver? Having to list all vendors/products that effectively talk the same protocol seems quite tedious/ineffective.

@DJawna
Copy link

DJawna commented May 3, 2024

Hello will this be merged? because i have a similar problem my nacon controller has the id:

3285:0616

currently i have simply changed the xpad kernel module myself, but i would like to use the official version ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants