[pending fix] chore(deps): Update smoldot to the latest version #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
niklasad1
approved these changes
Jan 26, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
reviewed
Jan 31, 2024
Comment on lines
178
to
183
| // non_finalized_headers_subscription(&api).await?; | ||
| finalized_headers_subscription(&api).await?; | ||
| runtime_api_call(&api).await?; | ||
| storage_plain_lookup(&api).await?; | ||
| dynamic_constant_query(&api).await?; | ||
| dynamic_events(&api).await?; | ||
| // runtime_api_call(&api).await?; | ||
| // storage_plain_lookup(&api).await?; | ||
| // dynamic_constant_query(&api).await?; | ||
| // dynamic_events(&api).await?; |
There was a problem hiding this comment.
Should these still be commented out?
There was a problem hiding this comment.
Yep, I've added a few debug logs in f14bf9a.
This is to help reproduce the issue from smoldot faster smol-dot/smoldot#1638.
I suggest putting this PR on pending until another smoldot version is published on crates io :D
lexnv
changed the title
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates smoldot to 0.17 and smoldot-light to 0.15.
Changes to repo:
Pending fix from:
chain_subscribeFinalizedHeadssubscription seems to not produce blocks smol-dot/smoldot#1638