feat(extension): supervised smoldot #2157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanleecode
force-pushed
the
feat/extension/supervised-smoldot
branch
3 times, most recently
from
e66bac5
to
49c5ef5
Compare
ryanleecode
force-pushed
the
feat/extension/supervised-smoldot
branch
from
695f7f7
to
12bd169
Compare
|
@jsdw tagging you for a review here since this issue is a bit trickey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1786
Adds a supervisor to detect when smoldot crashes/unresponsive by monitoring each chain that is added and polling it by getting the genesis hash. When a crash is detected, smoldot is restarted and this means you won't need to turn the extension on and off again.
However, the webpage/dapp will most likely require a refresh.
In terms of functionality, when you leave a dapp the chains it is connected to no longer are "unconnnected". they are watched forever until a smoldot restart happens. This is the compromise made to get this to work, but I think having it like this is better.
Avoiding any type of chainhead follow polling due to (somehow) getting chainhead follow subscription limit reached
Demo of smoldot crashing and it being restarted in the extension.
https://www.loom.com/share/59ecf161491f4a5884b0551be7a36698?t=111&sid=0d9e68c1-9833-47ce-848d-1de004cc87ba