feat(wallet-template): add account switching #2010
Conversation
| keysets: { | ||
| [key: string]: any | ||
| } | ||
| primaryKeysetName: string |
There was a problem hiding this comment.
let's default to the first key as primary and remove this key
There was a problem hiding this comment.
you still need to store something though. if the user selects an account, then closes the browser, and then re-opens it, the extension should remain on the same account.
There was a problem hiding this comment.
you are right.
I wonder if could be stored in window.localStorage but I'm not sure if that storage is shared between popup and extension pages.
There was a problem hiding this comment.
The name needs to be improved because there may be plain accounts that do not have a keyset.
There was a problem hiding this comment.
we can turn keyset into a typed union when we add plain accounts and then have plain accounts as a different variant. then handle each variant when decoded.
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/Accounts.tsx
Outdated
Show resolved
Hide resolved
ryanleecode
force-pushed
the
feat/wallet-template/accounts-switch
branch
from
66e2c7c
to
b51752e
Compare
| keysets: { | ||
| [key: string]: any | ||
| } | ||
| primaryKeysetName: string |
There was a problem hiding this comment.
you are right.
I wonder if could be stored in window.localStorage but I'm not sure if that storage is shared between popup and extension pages.
| keysets: { | ||
| [key: string]: any | ||
| } | ||
| primaryKeysetName: string |
There was a problem hiding this comment.
The name needs to be improved because there may be plain accounts that do not have a keyset.
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/Accounts.tsx
Outdated
Show resolved
Hide resolved
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/Accounts.tsx
Outdated
Show resolved
Hide resolved
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/AddAccount/index.tsx
Outdated
Show resolved
Hide resolved
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/Accounts.tsx
Outdated
Show resolved
Hide resolved
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/AddAccount/index.tsx
Outdated
Show resolved
Hide resolved
ryanleecode
force-pushed
the
feat/wallet-template/accounts-switch
branch
from
daf18ee
to
9dd6087
Compare
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/AddAccount/index.tsx
Outdated
Show resolved
Hide resolved
projects/wallet-template/src/containers/WalletPopup/pages/Accounts/SwitchAccount.tsx
Outdated
Show resolved
Hide resolved
ryanleecode
force-pushed
the
feat/wallet-template/accounts-switch
branch
from
8ef8f65
to
635d080
Compare
#1932