feat(wallet-template): add UserSignedExtensionInputs component #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kratico
commented
Mar 1, 2024
kratico
commented
ryanleecode
reviewed
Mar 1, 2024
| onChange(value: UserSignedExtensions["ChargeTransactionPayment"]): void | ||
| defaultValue?: number | ||
| } | ||
| const TipInput = ({ onChange, defaultValue = 0 }: TipInputProps) => { |
There was a problem hiding this comment.
should make sure its >= 0
There was a problem hiding this comment.
There is a min={0} in the <input>
<input
type="number"
defaultValue={Number(defaultValue)}
// @ts-expect-error TODO: improve bigint types
onChange={(e) => onChange(+e.target.value)}
min={0}
className="w-full py-2 px-3 border rounded leading-tigh"
/>
ryanleecode
approved these changes
Mar 1, 2024
kratico
force-pushed
the
feat/basic-signed-extension
branch
from
11999ab
to
891e9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.