Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lc-dapp): transfers #1923

Merged
merged 12 commits into from Mar 4, 2024
Merged

feat(lc-dapp): transfers #1923

merged 12 commits into from Mar 4, 2024

Conversation

ryanleecode
Copy link
Collaborator

@ryanleecode ryanleecode commented Mar 1, 2024 •
edited

Does a transfer and reports the transaction status in the UI.

#1894

@ryanleecode ryanleecode requested a review from kratico March 1, 2024 15:36
@ryanleecode ryanleecode marked this pull request as ready for review March 1, 2024 15:36
kratico
kratico suggested changes Mar 4, 2024
View reviewed changes
examples/light-client-dapp/src/hooks/useTransfer.ts Outdated Show resolved Hide resolved
examples/light-client-dapp/src/hooks/useTransfer.ts Outdated Show resolved Hide resolved
examples/light-client-dapp/src/components/Transfer.tsx Outdated Show resolved Hide resolved
examples/light-client-dapp/src/components/Transfer.tsx Outdated Show resolved Hide resolved
kratico
kratico approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@kratico kratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a 2nd pass on a different PR to check if the RxJS observables can be simplified.

@ryanleecode ryanleecode enabled auto-merge (squash) March 4, 2024 21:29
@ryanleecode ryanleecode merged commit 204eb55 into main Mar 4, 2024
12 of 13 checks passed
@ryanleecode ryanleecode deleted the feat/lc-dapp/transfer branch March 4, 2024 21:37
@substrate-connect substrate-connect mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratico kratico kratico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanleecode @kratico