Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wallet-popup #1904

Merged
merged 2 commits into from Feb 29, 2024
Merged

feat: add wallet-popup #1904

merged 2 commits into from Feb 29, 2024

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Feb 28, 2024

No description provided.

@kratico kratico marked this pull request as ready for review February 28, 2024 20:06
Comment on lines +15 to +29
const [signRequest, setSignRequest] = useState<SignRequest>()
const [signRequestId, setSignRequestId] = useState<string>()
useEffect(() => {
const init = async () => {
const signRequests = await rpc.client.getSignRequests()
// TODO: handle many signRequests
const keys = Object.keys(signRequests)
if (keys.length === 0) return
setSignRequestId(keys[0])
setSignRequest(signRequests[keys[0]])
}
init()
}, [])
if (!signRequestId || !signRequest) return null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll refactor this into hooks

Copy link
Collaborator

@ryanleecode ryanleecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kratico kratico merged commit 3bf56b4 into main Feb 29, 2024
12 of 13 checks passed
@kratico kratico deleted the feat/wallet-popup branch February 29, 2024 13:49
@ryanleecode
Copy link
Collaborator

#1894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants