Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The extension gets "stuck" in the past #1786

Open
Tracked by #2058
josepot opened this issue Jan 23, 2024 · 7 comments · Fixed by #2151
Open
Tracked by #2058

The extension gets "stuck" in the past #1786

josepot opened this issue Jan 23, 2024 · 7 comments · Fixed by #2151
Assignees

Comments

@josepot
Copy link
Contributor

josepot commented Jan 23, 2024

Issue Description

After a period of inactivity, then the extension stops announcing new blocks and nothing seems to work until you manually reset it.

image

Steps to reproduce the issue

Steps to reproduce the issue

  1. Use the extension in a DApp
  2. Put your laptop to sleep for a few minutes
  3. Try using the extension again

Describe the results you received

The extension stops working, no new blocks get announced and the DApps can't communicate with smoldot

Describe the results you expected

I expected for that not to happen

Substrate-Connect version

extension: 0.3.1 npm-package: 0.8.5

Provider

Chrome

Browser version

As I laready mentioned before: 0.3.1

Additional environment details

(This issue template is a huge PITA)

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting

Screenshots

No response

@ryanleecode ryanleecode self-assigned this Feb 29, 2024
@ryanleecode
Copy link
Collaborator

im able to further reproduce with the following ..

  1. load the demo app
  2. connect to a vpn (breaks ur current internet connect)
  3. reload the demo app

the app will nuke with smoldot panicing

{code: -32603, message: 'Error: panicked at /__w/smoldot/smoldot/light-base…5:35:\ncalled `Option::unwrap()` on a `None` value'}
code
: 
-32603
message
: 
"Error: panicked at /__w/smoldot/smoldot/light-base/src/runtime_service.rs:1845:35:\ncalled `Option::unwrap()` on a `None` value"
[[Prototype]]
: 
Object

@ryanleecode
Copy link
Collaborator

marking as blocked for now

smol-dot/smoldot#1712

@ryanleecode
Copy link
Collaborator

I haven't crashed or froze since the latest update. Will close this for now. Plz re-open if it happens again.

@ryanleecode
Copy link
Collaborator

nope still goes to sleep. reopened

@josepot
Copy link
Contributor Author

josepot commented Apr 29, 2024

According to the comment on #2151 :

This doesn't fix #1786 but reduces the likelihood of the extension getting stuck in the past

it seems that this issue was closed by accident.

@ryanleecode
Copy link
Collaborator

According to the comment on #2151 :

This doesn't fix #1786 but reduces the likelihood of the extension getting stuck in the past

it seems that this issue was closed by accident.

Yah github autoclosed it or something

@ryanleecode
Copy link
Collaborator

For visibility purposes, since most of the discussion took place in element, we are going to find a solution that restarts smoldot if it ever gets stucks.

To determine if it is stuck we will check if smoldot immediately responds to a follow event with a subscription id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
2 participants