Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camelCase transaction status to align with Substrate #3105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsdw
Copy link

@jsdw jsdw commented Mar 16, 2023

Hey! An error cropped up via Ink in trying to use Subxt to communicate with Smoldot:

error on call `wait_for_in_block`: Serialization(Error("unknown variant `Ready`, expected one of `future`, `ready`, `broadcast`, `inBlock`, `retracted`, `finalityTimeout`, `finalized`, `usurped`, `dropped`, `invalid`", line: 1, column: 8))', /Users/bruno/.cargo/git/checkouts/ink-1add513eda8f5a89/9c9215f/crates/e2e/src/xts.rs:270:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I believe the reason for the issue was that Smoldot's author_submitAndWatchExtrinsic returns transaction statuses whose variants aren't camelCased, whereas the Substrate RPC method does camelCase (see https://github.com/paritytech/substrate/blob/283106b19b85bc8deb232cfa624eed195f143541/client/transaction-pool/api/src/lib.rs#L106)

So I wonder whether you'd be open to applying the same camelCasing in Smoldot to align?

@jsdw jsdw changed the title camelCase transaction status to align with Substrate response camelCase transaction status to align with Substrat Mar 16, 2023
@jsdw jsdw changed the title camelCase transaction status to align with Substrat camelCase transaction status to align with Substrate Mar 16, 2023
@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant