Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce no-std compatibility in CI #1791

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Dec 15, 2021

Close #106

This is not passing, but this PR can be used as a way to track progress.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

Cargo.toml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@gilescope
Copy link
Contributor

Is it possible to compile smoldot for wasm32-unknown-unknown? Would be great to get that enforced in the CI too. I wanted to try and use it from a wgpu rendered bevy client on the browser but when I pull in the dep:

smoldot = { git= "https://github.com/paritytech/smoldot.git", default-features = false }

it grumbles about sql light which is odd as I told it no default features...

@tomaka
Copy link
Contributor Author

tomaka commented Apr 18, 2022

wasm32-unknown-unknown has a std, so this is off topic.
But yes, the smoldot and smoldot-light-base libraries compile for Wasm, that is checked by CI.

@tomaka tomaka added the blocked Can't work on this issue because it is blocked on something out of our control label Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't work on this issue because it is blocked on something out of our control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the library compile for no_std
2 participants