Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the library compile for no_std #106

Open
tomaka opened this issue Oct 28, 2020 · 4 comments · May be fixed by #1791
Open

Make the library compile for no_std #106

tomaka opened this issue Oct 28, 2020 · 4 comments · May be fixed by #1791
Labels
blocked Can't work on this issue because it is blocked on something out of our control

Comments

@tomaka
Copy link
Contributor

tomaka commented Oct 28, 2020

Everything in the title.

For obvious reasons, only wasmi would be supported.
@tomaka tomaka mentioned this issue Oct 29, 2020
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Oct 29, 2020 •
edited

Summary after #116:

  • parity-multiaddr doesn't support no_std.
  • num-rational needs a bugfix for no_std to work.
  • slab needs a bugfix for no_std to work and is completely unmaintained. We probably need to publish a fork.
  • nom supports no_std in master but not in the crates.io version.
  • prost supports no_std in master but not in the crates.io version. However, some brief testing of the git version showed that it still tried to use std anyway.

@tomaka
Copy link
Contributor Author

tomaka commented Oct 30, 2020

I forgot snow, which doesn't support no_std either.

@tomaka tomaka mentioned this issue Jan 5, 2021
Merged
@tomaka tomaka mentioned this issue Feb 28, 2021
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Feb 28, 2021 •
edited

After #579, smoldot itself compiles for no_std, but not all of its dependencies.
In order to consider this finished, a CI check should be added that compiles smoldot for a platform that doesn't have a std.

@tomaka tomaka linked a pull request Dec 15, 2021 that will close this issue
Draft
@tomaka tomaka added the blocked Can't work on this issue because it is blocked on something out of our control label Dec 17, 2021
@tomaka
Copy link
Contributor Author

tomaka commented Nov 8, 2022

Still blocked on snow.
At the moment, the compilation fails on subtle, but it's because its std feature is pulled by snow.

@tomaka tomaka mentioned this issue Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Can't work on this issue because it is blocked on something out of our control
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce no-std compatibility in CI tomaka/substrate-lite-1
1 participant
@tomaka