Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets Events for Deposited and Withdrawn #4312

Merged
merged 12 commits into from Apr 30, 2024
Merged

Assets Events for Deposited and Withdrawn #4312

merged 12 commits into from Apr 30, 2024

Conversation

pandres95
Copy link
Contributor

@pandres95 pandres95 commented Apr 26, 2024 •
edited

Closes #4308

Polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

@pandres95 pandres95 requested a review from a team as a code owner April 26, 2024 16:16
liamaharon
liamaharon approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great idea hooking into the fungibles methods :)

substrate/frame/assets/src/lib.rs Outdated Show resolved Hide resolved
@liamaharon liamaharon added the T2-pallets This PR/Issue is related to a particular pallet. label Apr 26, 2024
@liamaharon
Copy link
Member

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 26, 2024 •
edited

@liamaharon https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6072641 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-30a8d951-7fe5-4ed8-abc2-89d460961ea8 to cancel this command or bot cancel to cancel all commands in this pull request.

liamaharon
liamaharon approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@liamaharon liamaharon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRDoc also please

@command-bot
Copy link

command-bot bot commented Apr 26, 2024

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6072641 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6072641/artifacts/download.

@liamaharon
Copy link
Member

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@pandres95 Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

liamaharon
liamaharon reviewed Apr 26, 2024
View reviewed changes
prdoc/pr_4312.prdoc Outdated Show resolved Hide resolved
@liamaharon
Copy link
Member

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@liamaharon A referendum for a small (20 DOT) tip was successfully submitted for @pandres95 (12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR on polkadot).

Referendum number: 717.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

@pandres95 pandres95 changed the title Assets-events-deposit-withdraw Assets Events for Deposited and Withdrawn Apr 26, 2024
franciscoaguirre
franciscoaguirre approved these changes Apr 29, 2024
View reviewed changes
prdoc/pr_4312.prdoc Outdated Show resolved Hide resolved
@pandres95 @franciscoaguirre
Update prdoc/pr_4312.prdoc
a180ad0 
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
@liamaharon liamaharon added this pull request to the merge queue Apr 30, 2024
Merged via the queue into paritytech:master with commit 1fb058b Apr 30, 2024
138 of 139 checks passed
@pandres95 pandres95 deleted the assets-events-deposit-withdraw branch April 30, 2024 13:34
Morganamilo pushed a commit that referenced this pull request May 2, 2024
@pandres95 @franciscoaguirre @Morganamilo
Assets Events for Deposited and Withdrawn (#4312)
63bd05e 
Closes #4308

Polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

---------

Co-authored-by: command-bot <>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@kianenigma kianenigma kianenigma approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assets Events for Deposited and Withdrawn
5 participants
@pandres95 @liamaharon @franciscoaguirre @kianenigma @joepetrowski