Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semver CI check #4279

Merged
merged 11 commits into from May 8, 2024
Merged

Add semver CI check #4279

merged 11 commits into from May 8, 2024

Conversation

Morganamilo
Copy link
Contributor

This checks changed files against API surface changes against what the
prdoc says.

It will error if the detected semver change is greater than the one
listed in the prdoc. It will also error if any crates were touched but
not mentioned in the prdoc.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 25, 2024 07:46
@Morganamilo Morganamilo force-pushed the morganamilo/validate branch 8 times, most recently from 61cdc32 to 06ad5dd Compare April 25, 2024 15:01
@Morganamilo Morganamilo added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Apr 25, 2024
@Morganamilo Morganamilo marked this pull request as ready for review April 25, 2024 15:37
@Morganamilo Morganamilo requested a review from a team as a code owner April 25, 2024 15:37
@Morganamilo
Copy link
Contributor Author

This is finally ready after a lot of headache. See here https://github.com/paritytech/polkadot-sdk/actions/runs/8835275152/job/24259014297?pr=4279 for the output of the action. b4c1a79 is just to get some errors to show off the output. It will be reverted before merge.

@Morganamilo
Copy link
Contributor Author

This is just a day after the 1.11 branch off. So it should be feasible to check over the PRdocs that have gotten in before this merge and go with a prdoc based release on the next release.

ggwpez
ggwpez requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until i posted the PSA, so we dont repeat the situation from last time 😅

@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/psa-polkadot-sdk-enabling-semver/7616/1

@ggwpez
Copy link
Member

ggwpez commented Apr 30, 2024

Can you suppress compiler warnings? I think that nightly may have more warnings than stable. If it not just warns, but fails to compile, then we have to fix it though.

@Morganamilo
Copy link
Contributor Author

I only just turned them them all because the build was failing to figure out why it was failing after pulling from master. Right now it's all or nothing cause the library isn't very good about controlling it.

I can probably redirect the output to a buffer then dump the buffer on error but focusing on the last curicial bits first.

@Morganamilo Morganamilo requested a review from a team as a code owner May 2, 2024 16:58
@Morganamilo
Add semver CI check
3789306 
This checks changed files against API surface changes against what the
prdoc says.

It will error if the detected semver change is greater than the one
listed in the prdoc. It will also error if any crates were touched but
not mentioned in the prdoc.
@Morganamilo
Update parity-publish
3713c2f
@Morganamilo
Remove dev version
9a57823
@Morganamilo
Copy link
Contributor Author

Can you suppress compiler warnings? I think that nightly may have more warnings than stable. If it not just warns, but fails to compile, then we have to fix it though.

Fixed this by passing rustflags to silence warnings.

@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label May 7, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6159499

@Morganamilo Morganamilo enabled auto-merge May 8, 2024 12:35
@ggwpez
Update lockfile
bd5516a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@Morganamilo Morganamilo added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit 6fdb522 May 8, 2024
143 of 146 checks passed
@Morganamilo Morganamilo deleted the morganamilo/validate branch May 8, 2024 16:44
paritytech-ci pushed a commit that referenced this pull request May 8, 2024
@Morganamilo @ggwpez
Add semver CI check (#4279)
8346b8c 
This checks changed files against API surface changes against what the
prdoc says.

It will error if the detected semver change is greater than the one
listed in the prdoc. It will also error if any crates were touched but
not mentioned in the prdoc.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@liamaharon liamaharon liamaharon approved these changes

@bkchr bkchr Awaiting requested review from bkchr

@acatangiu acatangiu Awaiting requested review from acatangiu

@andresilva andresilva Awaiting requested review from andresilva

@koute koute Awaiting requested review from koute

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Morganamilo @Polkadot-Forum @ggwpez @paritytech-cicd-pr @EgorPopelyaev @liamaharon