Update RuntimeVerison type and use system_version to derive extrinsics root StateVersion instead of V0
#4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
@bkchr I had looked through the failed tests and not sure if the failures are related to changes in this PR. Can you confirm? If not where should I look at to fix these tests ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
RuntimeVersion::state_versiontosystem_versionRuntime::system_versionto derive extrinsics rootStateVersioninstead of defaultStateVersion::V0This PR should not be breaking any existing chains so long as they use same
RuntimeVersion::state_versionforRuntime::system_versionUsing
RuntimeVersion::system_version = 2will make the extrinsics root to useStateVersion::V1instead ofV0RFC for this change - polkadot-fellows/RFCs#42