Remove hard-coded indices from pallet-xcm tests

[chungquantin]

ISSUE

• Link to issue: [tests] Remove hard-coded error indices in pallet-xcm tests #4237

DESCRIPTION

Remove all ModuleError with hard-coded indices to pallet Error. For example:

Err(DispatchError::Module(ModuleError {
	index: 4,
	error: [2, 0, 0, 0],
	message: Some("Filtered")
}))

To

let expected_result = Err(crate::Error::<Test>::Filtered.into());
assert_eq!(result, expected_result);

TEST OUTCOME

test result: ok. 74 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

[ggwpez]

Thanks! Looks better now.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6046329

[acatangiu]

bot fmt

[command-bot]

@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6054776 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-b6f3d8c5-14fc-40fc-a7fc-f0a97950bc6c to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@acatangiu Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6054776 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6054776/artifacts/download.

[acatangiu]

@chungquantin the bot is not allowed to push to your fork, you'll have to cargo +nightly fmt --all yourself and push the changes.

[acatangiu]

Or you could simply manually make the change suggested by CI here: https://github.com/paritytech/polkadot-sdk/actions/runs/8827160816/job/24233986818?pr=4248