Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets Events for Deposited and Withdrawn #4308

Closed
joepetrowski opened this issue Apr 26, 2024 · 1 comment · Fixed by #4312
Closed

Assets Events for Deposited and Withdrawn #4308

joepetrowski opened this issue Apr 26, 2024 · 1 comment · Fixed by #4312
Assignees
@liamaharon
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@joepetrowski
Copy link
Contributor

We have events for balances when they are deposited or withdrawn from an account. A lot of services like block indexers rely on these for account balance computation rather than reading on-chain state. We should provide the same events for assets so that they can use the same logic in integration.

Assigning @liamaharon but could also be a good mentor/first issue.
@joepetrowski joepetrowski added the T2-pallets This PR/Issue is related to a particular pallet. label Apr 26, 2024
@liamaharon liamaharon added the C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. label Apr 26, 2024
@liamaharon
Copy link
Member

@pandres95 will take it :)

@pandres95 pandres95 mentioned this issue Apr 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 30, 2024
@pandres95 @franciscoaguirre
Assets Events for Deposited and Withdrawn (#4312)
1fb058b 
Closes #4308

Polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

---------

Co-authored-by: command-bot <>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Morganamilo pushed a commit that referenced this issue May 2, 2024
@pandres95 @franciscoaguirre @Morganamilo
Assets Events for Deposited and Withdrawn (#4312)
63bd05e 
Closes #4308

Polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

---------

Co-authored-by: command-bot <>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamaharon liamaharon

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assets Events for Deposited and Withdrawn pandres95/polkadot-sdk
2 participants
@liamaharon @joepetrowski