Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/query: Scale merge profiles by period for diffing merges #4166

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

metalmatze
Copy link
Member

  • pkg/parcacol: Aggregate period and duration by timestamp
  • pkg/query: Multiply the base and compare profiles for diffs

Something is still slightly off with the multiplication of values and diff values.

Copy link

alwaysmeticulous bot commented Nov 28, 2023

✅ Meticulous spotted zero visual differences across 391 screens tested: view results.

Last updated for commit d3861e5. This comment will update as new commits are pushed.

@metalmatze
Copy link
Member Author

There's still a memory leak I need to fix. We can probably remove the duration from the underlying ArrowDiffSchema again. It's not used. Some other clean-ups are left to do.

pkg/query/columnquery.go Outdated Show resolved Hide resolved
This is for merged profiles. To be able to diff/compare merged profiles
Based on the merged profile's duration we multiply either the base or the compare profile to end up with roughly the same duration for diffing.
We had to take the period/valueCount for each timestamp. Now the merged profile's period makes sense and we can use it to properly scale values.
@metalmatze metalmatze changed the title pkg/query: Normalize merge profile duration for diffing pkg/query: Scale merge profiles by period for diffing merges Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant