Have active classes automatically include the Actor trait #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trait `Actor` is defined in the `Std` module, and defines three methods: `await`, `suspend`, and `run_attached_closure`. Automatically including this in active classes replaces the old behaviour of implicitly defining the two former methods in active classes. The changelog looks big for such a change. This is because I also fixed a bug that would incorrectly assume that a modeless, trait-less, class was an active class (and thus included the `Actor` trait). This means that the `Main` class now _has to_ be declared as `active`, which some test cases did not.
EliasC
force-pushed
the
features/actor-trait
branch
from
8f06beb
to
30828e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trait
Actoris defined in theStdmodule, and definesthree methods:
await,suspend, andrun_attached_closure.Automatically including this in active classes replaces the old
behaviour of implicitly defining the two former methods in active
classes.
The changelog looks big for such a change. This is because I also
fixed a bug that would incorrectly assume that a modeless,
trait-less, class was an active class (and thus included the
Actortrait). This means that theMainclass now has to bedeclared as
active, which in some test cases, it was not.