3D ile ödeme #86
Open
3D ile ödeme #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2016 15:59
| @@ -54,7 +57,7 @@ | |||
| */ | |||
| protected $dispatcher; | |||
|
|
|||
| public function __construct(AbstractConfiguration $configuration) | |||
| public function __construct(AbstractConfiguration $configuration = null) | |||
There was a problem hiding this comment.
Adaptörleri hangi durumda ayarlarını vermeden init etmemiz gerekiyor? Niye null eklendi?
|
@travijuu öncelikle ellerine sağlık, Hızlı bir göz gezdirdim.
|
| @@ -230,6 +241,11 @@ protected function formatInstallment($installment) | |||
| return (!is_numeric($installment) || intval($installment) <= 1) ? '' : $installment; | |||
| } | |||
|
|
|||
| protected function formatCardNumber($cardNumber) | |||
There was a problem hiding this comment.
FormatCardNumber fonksiyonuna Adaptör'lerde gerek yok.
İlla kart numarasını temizleyecek isek $request->setCardNumber fonksiyonunun içinde gerekli işlemleri yapabiliriz.
Aşağıdaki şekilde bir temizleme daha garanti olacaktır;
return preg_replace('@[^0-9]@', '', $cardNumber);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NestPay, Posnet ve GVP için 3D ile ödeme seçeneği eklendi.