Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration test for pcr_extend #437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkulke
Copy link

@mkulke mkulke commented Sep 28, 2023

I didn't find a test for extending PCRs in the repo, it would be useful also as a reference

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@Superhepper
Copy link
Collaborator

Superhepper commented Sep 28, 2023

Well this is nice. But I think this is in the wrong place. pcr_extend is an actual Esys API so it should be a context method.

So I think a better place for this test would be here.

Or maybe att it as an example in the documentation for that method if it is not properly documented.

@mkulke
Copy link
Author

mkulke commented Sep 29, 2023

Well this is nice. But I think this is in the wrong place. pcr_extend is an actual Esys API so it should be a context method.

So I think a better place for this test would be here.

Or maybe att it as an example in the documentation for that method if it is not properly documented.

Ah indeed, thx for clarifying. the linked test seems to cover pcr_extend. from glancing over it, I assumed it was testing some advanced tpm ceremony, but it's more or less the same test. I'll change this into an example similar to the hmac one and then you can decide whether it's a helpful addition.

@Superhepper
Copy link
Collaborator

Is this still in active development or should this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants