Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add alloy-compat for signature and transaction #8197

Merged
merged 2 commits into from May 15, 2024
Merged

chore: add alloy-compat for signature and transaction #8197

merged 2 commits into from May 15, 2024

Conversation

Vid201
Copy link
Contributor

@Vid201 Vid201 commented May 10, 2024

Addresses #8177

Other types already either have alloy-compat or are imported from alloy

@Vid201 Vid201 requested a review from gakonst as a code owner May 10, 2024 12:25
mattsse
mattsse requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the compat stuff to a standalone alloy_compat.rs file

could you please move that there?

@mattsse mattsse added the C-enhancement New feature or request label May 13, 2024
@Vid201
Copy link
Contributor Author

Vid201 commented May 13, 2024

I moved the compat stuff to a standalone alloy_compat.rs file

could you please move that there?

updated

@mattsse mattsse added this pull request to the merge queue May 15, 2024
Merged via the queue into paradigmxyz:main with commit aa5c52b May 15, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vid201 @mattsse