feat: add actions lint to pull request workflow #8183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
approved these changes
May 10, 2024
mattsse
approved these changes
May 12, 2024
mattsse
force-pushed
the
dan/yaml-lint-workflows
branch
from
937ebd7
to
ab76089
Compare
|
@Rjected there a few shellcheck errors, not obvious to me how to fix, I'm also okay with ignoring them |
yeah since this already should be useful for detecting basic yaml errors, it should be fine to ignore the shellcheck errors for now |
Rjected
requested review from
rakita,
joshieDo,
shekhirin and
rkrasiuk
as code owners
Rjected
force-pushed
the
dan/yaml-lint-workflows
branch
from
f3c63b8
to
01c9ff0
Compare
DaniPopes
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I've been having yaml pain, we should add basic linting to github actions workflows on PRs, merge queue, and push