feat: enable parallel storage root computation on canonical chain write #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
reviewed
May 6, 2024
| ParallelStateRoot::new(consistent_view, hashed_state.clone()) | ||
| .incremental_root_with_updates() | ||
| .map(|(root, updates)| (root, Some(updates))) | ||
| .map_err(ProviderError::from)?; |
There was a problem hiding this comment.
this should be BlockValidationError as before
There was a problem hiding this comment.
I've added an impl for going from ParallelStateRootError directly to CanonicalError, ptal
| .provider()? | ||
| // State root calculation can take a while, and we're sure no write transaction | ||
| // will be open in parallel. See https://github.com/paradigmxyz/reth/issues/6168. | ||
| .disable_long_read_transaction_safety(); |
There was a problem hiding this comment.
thinking if worth configuring this in the consistent view
There was a problem hiding this comment.
I can add these changes if needed, lmk
fgimenez
force-pushed
the
fgimenez/enable-parallel-storage-root-computation
branch
from
67a4847
to
25c0a0e
Compare
|
gm @fgimenez next steps here? |
emhane
added
C-perf
|
bump @rkrasiuk for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.