feat: bsc p2p network #8061
Merged
feat: bsc p2p network #8061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
May 2, 2024
crates/ethereum-forks/src/forkid.rs
Outdated
Comment on lines
300
to
304
| /// Set the current fork id | ||
| pub fn set_fork_id(&mut self, fork_id: ForkId) { | ||
| self.cache.fork_id = fork_id; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think we're using this, right?
setting the forkid on network alone is sufficient, I suppose?
There was a problem hiding this comment.
I'm using it to set it manually because of the various forks the bsc has, I couldn't make a valid forkhash without
examples/bsc-p2p/src/chain_cfg.rs
Outdated
examples/bsc-p2p/src/main.rs
Outdated
| .chain_spec(bsc_chain_spec()) | ||
| .set_head(head()) | ||
| .listener_addr(local_addr) | ||
| .build(NoopProvider::default()); |
There was a problem hiding this comment.
there is
reth/crates/net/network/src/config.rs
Line 454 in 9eb7d96
onbjerg
previously requested changes
May 5, 2024
mattsse
approved these changes
May 22, 2024
Thank you! I will try to figure out why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7738
I had to add a method to set
ForkIdmanually because of different bsc forks, let me know if there's a better way to do it