Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ParadeDB Deployment Scripts #1081

Closed
wants to merge 4 commits into from
Closed

Conversation

philippemnoel
Copy link
Collaborator

Ticket(s) Closed

  • Closes #N/A

What

Several projects we admire, like Airbyte and PostHog, have Bash scripts to facilitate deploying their product. This is especially useful to make deployment a single command, provide a simple tutorial for users to get started, and help configure a few parameters.

We'll soon be adding support for SSL and High Availability on our Dockerfile, and having them done as part of a script will be easier for users. This also gives us the opportunity to ask our users for their email, if they'd like to share it. To PR adds such scripts for ParadeDB, pg_search, and pg_analytics.

Why

^

How

I followed the model of PostHog and Airbyte.

Tests

Each script needs to be tested on macOS and Linux Ubuntu. I don't intend for us to support Windows at this time.

  • ParadeDB - macOS
  • ParadeDB - Linux Ubuntu
  • pg_search - macOS
  • pg_search - Linux Ubuntu
  • pg_analytics - macOS
  • pg_analytics - Linux Ubuntu

@neilyio
Copy link
Contributor

neilyio commented Apr 24, 2024

This looks awesome, but I'm a little concerned we'll break it and users will be the first to find out. Do you have any ideas of how we could have automated tests for this?

@philippemnoel
Copy link
Collaborator Author

This looks awesome, but I'm a little concerned we'll break it and users will be the first to find out. Do you have any ideas of how we could have automated tests for this?

Tbh I don't think it's really worth it to add tests to this. It's going to be difficult and I doubt this will break often because we should hopefully never change it (?)

@philippemnoel philippemnoel marked this pull request as draft April 24, 2024 17:07
@philippemnoel philippemnoel force-pushed the phil/deploy-script branch 3 times, most recently from 481fc44 to ef43dec Compare May 5, 2024 12:14
@philippemnoel philippemnoel force-pushed the phil/deploy-script branch 2 times, most recently from 95d4a9f to d763ac5 Compare May 24, 2024 21:10
@philippemnoel
Copy link
Collaborator Author

Closing until resumed

@philippemnoel philippemnoel deleted the phil/deploy-script branch May 30, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants