Rotwing guidance bank fix #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautierhattenberger
previously requested changes
May 2, 2024
dewagter
dismissed
gautierhattenberger’s stale review
The setting in the GCS is still in radians.
|
You have |
dewagter
force-pushed
the
rotwing_guidance_bank_fix
branch
from
ac1cda0
to
68faaf1
Compare
|
PR updated! |
|
Thanks @dewagter and @gautierhattenberger for looking into this, didn't know the setting could also be configured with an alt_unit. Like this it works! |
|
Some stuff seem to be merged with #3274 already. Can you rebase on master to check ? Or we just believe in git... |
Co-authored-by: Gautier Hattenberger <gautier.hattenberger@enac.fr>
dewagter
force-pushed
the
rotwing_guidance_bank_fix
branch
from
e733c04
to
7bc65a5
Compare
|
Rebased on master works fine. |
dewagter
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EwoudSmeur, please verify