Fix bug in new agent API #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is valid to create multiple agents with the same IP address. Remove test that did not allow this. In the console, it is perfectly legal (and make sense). For example, creating an agent for each switch port. All the agents will refer to the same switch IP address
|
I am writing a python script that adds agents (and modules) for each switch port. In the console, it works with no problem. However, when I tried to do using the API, I got an error that the agent cannot be created since the IP address is already used. It seems that this is a bug (I don't understand what case you did try to prevent, but the code did not make sense) I hope that I am right, at least for me it is working... |
This bug caused group filtering was always applied
|
I have fixed yet another bug in get_all_agents Unless there was a group filter, nothing was returned (or all agents were returned if the API invocation URL had no 'other' field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is valid to create multiple agents with the same IP address. Remove test that did not allow this.
In the console, it is perfectly legal (and make sense). For example, creating an agent for each switch port. All the agents will refer to the same switch IP address