Fix Pandora Console installation in strict SQL mode #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stricter SQL and compatible with more database engines Better could be to omit the column completely Signed-off-by: Vicente Jimenez Aguilar <googuy@gmail.com>
No implicit value provided so it is better to not try to insert id_np and let database engine automatically increments its value Stricter and more compatible SQL Signed-off-by: Vicente Jimenez Aguilar <googuy@gmail.com>
Those defaults are present in pandoradb_migrate_6.0_to_7.0.mysql.sql It works for MariaDB since version 10.2.1 https://mariadb.com/kb/en/create-table/#default-column-option And no current MySQL version supports default value in text columns https://dev.mysql.com/doc/refman/8.0/en/blob.html Database engines that do not support default values in text simply throws a warning when creating or altering tables Signed-off-by: Vicente Jimenez Aguilar <googuy@gmail.com>
Avoids errors for data engines that do not accept default value in text columns and are run in strict SQL mode when installer load initial data. Inspection of PHP code needs to be done to avoid any futher error at runtime for a database engine without default value in text columns and run in strict SQL mode. Signed-off-by: Vicente Jimenez Aguilar <googuy@gmail.com>
Installing Pandora Console with a database in SQL strict mode when creating network components with id_nc 786 and up produces many errors 1366 for incorrect values types and 1265 for truncated data Apparently, values are wrongly placed but in permisive mode those values get replaced with just a warning and others that type match get inserted in wrong column Signed-off-by: Vicente Jimenez Aguilar <googuy@gmail.com>
vice
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to make Pandora FMS work in SQL strict mode.
For now just the installation of the Pandora Console was fixed. Installed in a MariaDB Galera Cluster with its default SQL strict mode. Other database use by Pandora Server for example have issues with SQL strict mode.
I think I have found that network components with id_nc 786 and up try to insert wrong values. See issue #145 . Once this issue is fixed, commit 84df0fb could be reverted.
Catching errors is one of the main reason to try to comply with SQL strict mode.