-
-
Notifications
You must be signed in to change notification settings - Fork 17.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD, CI: Use cibuildwheel
to build Emscripten/Pyodide wheels, push nightlies to Anaconda.org
#58647
base: main
Are you sure you want to change the base?
BLD, CI: Use cibuildwheel
to build Emscripten/Pyodide wheels, push nightlies to Anaconda.org
#58647
Conversation
.github/workflows/wheels.yml
Outdated
if: >- | ||
(github.event_name == 'schedule') || | ||
(github.event_name == 'workflow_dispatch') && | ||
(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && ( ! endsWith(github.ref, 'dev0'))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition can probably be skipped, because the intention of this PR is not to upload to https://anaconda.org/multibuild-wheels-staging/pandas,
|
||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: pyodide_wheel | ||
path: ./wheelhouse/*.whl | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have included this step in case it is needed to inspect the binary and do some debugging – happy to remove it based on what is suggested.
scientific-python-nightly-wheels
)
Looks like cibuildwheel might be adding pyodide here Maybe we should wait for that PR? |
Hi @lithomas1, I would advise holding off on that PR – it's stalled for many reasons, for example the fact that Pyodide does releases bi-annually with updated Python versions and Emscripten versions which will break the ABI – i.e., while the specification for breaking changes and ABI stability for the platform might exist, it has not been formalised through the means of a PEP yet; and because PyPI has not yet received support through a PEP for formalising the wasm32 tag through |
I ended up asking around on that PR and it has been merged now after more than a year of effort; I would still recommend using this existing configuration because it's much more stable and it will allow us to get these wheels uploaded to Anaconda.org much quicker, but in any case, that's not a high-priority pressing issue right now, so I would not mind if there is a delay with that and I understand that the review process can take time, running on its own accord. |
4e555c1
to
1b92b74
Compare
scientific-python-nightly-wheels
)cibuildwheel
to build Emscripten/Pyodide wheels, push nightlies to Anaconda.org
Both the wheel build and the tests pass 🎉: https://github.com/pandas-dev/pandas/actions/runs/9307939926/job/25620279093 I'll convert this to a draft for now – I will mark it as ready for review as soon as a stable |
pandas
in CI #57896 as stated in ENH: out-of-tree Pyodide builds in CI forpandas
#57891doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Description
This PR duplicates the Pyodide wheel builder job that was set up in #57896 into
wheels.yml
, except that in this case the wheel is not tested and the wheel builder usescibuildwheel
enabled with Pyodide to build the wheels. Subsequently, theupload_wheels.sh
script will be used with the appropriate repository secret to upload the Pyodide wheel to https://anaconda.org/scientific-python-nightly-wheels/pandas.Additional context
jupyterlite-sphinx
that acts upon doctest-based examples. The blocker in that regard is setting up a method to pre-install these wheels to provide them to thejupyterlite-pyodide-kernel
and make them available at run time, and progress is being made in this area.Adding an xref for tracking purposes, the action from
main
will be used until a stable release ofcibuildwheel
is available that can build Pyodide wheels: pypa/cibuildwheel#1456