Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compute_dict_like to get all columns #58452

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update compute_dict_like to get all columns #58452

wants to merge 11 commits into from
+149 −5

Conversation

undermyumbrella1
Copy link
Contributor

@undermyumbrella1 undermyumbrella1 commented Apr 27, 2024 •
edited

@undermyumbrella1 undermyumbrella1 marked this pull request as draft April 27, 2024 15:29
@undermyumbrella1 undermyumbrella1 force-pushed the fix/grouby_agg_dict_input_dup_columns branch from 75f593e to e8f3172 Compare April 28, 2024 14:36
@undermyumbrella1 undermyumbrella1 force-pushed the fix/grouby_agg_dict_input_dup_columns branch from b2ee3b4 to 79a8ea6 Compare April 28, 2024 15:36
@undermyumbrella1 undermyumbrella1 marked this pull request as ready for review April 28, 2024 16:26
rhshadrach
rhshadrach requested changes Apr 29, 2024
View reviewed changes
pandas/core/apply.py Outdated Show resolved Hide resolved
pandas/core/apply.py Outdated Show resolved Hide resolved
pandas/core/apply.py Show resolved Hide resolved
@undermyumbrella1 undermyumbrella1 force-pushed the fix/grouby_agg_dict_input_dup_columns branch from c0ddcdd to 31b05af Compare May 2, 2024 09:15
@undermyumbrella1
Copy link
Contributor Author

Thank you for the review, I have added comments as per the review.

@rhshadrach
Copy link
Member

Thanks for the patience here @undermyumbrella1 - I should be able to get to this by Friday.

rhshadrach
rhshadrach requested changes May 10, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in the for loop that I was trying to change looks good. In general it'd be best if we didn't have to split up a DataFrame into Series for performance, but to flexibly handle all the different cases we need to it doesn't seem possible to me.

pandas/tests/groupby/aggregate/test_aggregate.py Show resolved Hide resolved
rhshadrach
rhshadrach approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

@undermyumbrella1 - looks like some unrelated failures, can you merge main to make sure.

@rhshadrach rhshadrach added Bug Apply Apply, Aggregate, Transform labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform Bug Groupby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: groupby.agg fails when input has duplicate columns and dict input
3 participants
@undermyumbrella1 @rhshadrach @mroeschke