Show completions with and without params #699
Open
+34
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases I don't want completion with snippets:
Assume cursor is at
|
and completions are invoked. Applying completion will insert snippet and I must delete it in order to have just class/function name.IMO there are no way we can properly decide to include params or not.
My proposal is to include both candidates without and with params in completions list.
This PR add new option
include_params_both
. Withinclude_params
andinclude_params_both
enabled completions list will include both variants.There also side change:
label
is always equal toinsertText
in completion item. Is there any reason to completion label include all params?