Component (Draft) #132
Component (Draft) #132
Conversation
| @@ -4,6 +4,12 @@ project(aruco_ros) | |||
| if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
| add_compile_options(-Wall -Wextra -Wpedantic) | |||
| endif() | |||
|
|
|||
| # compile release by default | |||
| if(NOT CMAKE_BUILD_TYPE) | |||
| add_executable(marker_publisher src/marker_publish.cpp | ||
| src/aruco_ros_utils.cpp) | ||
| target_include_directories(marker_publisher | ||
| add_library(marker_publisher_component |
|
|
||
| rclcpp_components_register_node(marker_publisher_component | ||
| PLUGIN "aruco_ros::ArucoMarkerPublisherComponent" | ||
| EXECUTABLE marker_publisher) |
There was a problem hiding this comment.
executable to maintain current behavior
There was a problem hiding this comment.
Yes, better to maintain current behaviour
| install(TARGETS marker_publisher single double | ||
| DESTINATION lib/${PROJECT_NAME}) | ||
| install(TARGETS marker_publisher_component single double | ||
| LIBRARY DESTINATION lib |
| #include "tf2_geometry_msgs/tf2_geometry_msgs.hpp" | ||
| #include "tf2_ros/buffer.h" |
| @@ -4,6 +4,12 @@ project(aruco_ros) | |||
| if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
| add_compile_options(-Wall -Wextra -Wpedantic) | |||
| endif() | |||
|
|
|||
| # compile release by default | |||
| if(NOT CMAKE_BUILD_TYPE) | |||
| #include "tf2_geometry_msgs/tf2_geometry_msgs.hpp" | ||
| #include "tf2_ros/buffer.h" |
|
|
||
| rclcpp_components_register_node(marker_publisher_component | ||
| PLUGIN "aruco_ros::ArucoMarkerPublisherComponent" | ||
| EXECUTABLE marker_publisher) |
There was a problem hiding this comment.
Yes, better to maintain current behaviour
|
hi @saikishor , thank you so much for the review! I'll continue working on it a little, add some tests etc. Will let you know once ready. |
Thank you so much! |
|
sorry this PR is getting a little out of hand and might be difficult for review. I did some unnecessary formatting. But now supports parameter re-configure and the current behavior should remain unchanged. Happy to role back a little on the formatting changes and open new PR. |
Problem
High latency over DDS for high resolution cameras like
zed2iSolution
Component-based architecture for intra-process communication. Initially for
marker_publisherTo do
marker_publishcomponentsimple_doublecomponentsimple_singlecomponentConvenience launch mixins(better other PR)Current components
Notes
Could you please give me a hand here @Noel215, thank you so much!