Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced "System.Data.SqlClient" with "Microsoft.Data.SqlClient" #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

primez
Copy link

@primez primez commented Apr 9, 2024

Update usage of "System.Data.SqlClient" to "Microsoft.Data.SqlClient"

Description

This pull request updates the usage of "System.Data.SqlClient" to "Microsoft.Data.SqlClient" throughout the codebase. The switch to "Microsoft.Data.SqlClient" aligns with the latest best practices and recommendations from Microsoft.
Check more information here - https://devblogs.microsoft.com/dotnet/introducing-the-new-microsoftdatasqlclient/

Changes Made

  • Replaced all occurrences of "System.Data.SqlClient" with "Microsoft.Data.SqlClient" in the codebase.
  • Updated relevant import statements and namespaces.

Motivation

"Microsoft.Data.SqlClient" is the recommended ADO.NET provider for SQL Server from Microsoft, offering improved performance, security, and compatibility with modern .NET frameworks and tooling. By migrating to "Microsoft.Data.SqlClient", we ensure compatibility with future updates and leverage the latest features and optimizations provided by Microsoft.

Testing

  • Tested the updated code locally to ensure it compiles without errors.
  • Conducted manual testing to verify the functionality remains intact after the replacement.
  • Used the updated compiled DLLs in a proprietary project instead of nuget packages and it worked

@primez
Copy link
Author

primez commented Apr 15, 2024

Hello @paillave. In case you haven't received a notification about the creation of this PR, I would like to bring your attention to it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant