Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOPAE-1164] Fix infinite scroll in InstitutionServicesScreen #5774

Merged
merged 5 commits into from
May 16, 2024

Conversation

adelloste
Copy link
Member

Short description

This PR fixes the infinite scroll in InstitutionServicesScreen by removing external ScrollView because the FlatList inside animated ScrollView causes infinite triggering of the onEndReached method without even scrolling.

How to test

Using io-dev-api-server, navigate to the services tab and tap an institution. Check that infinite scroll works correctly and that onEndReached is triggered only when scrolling to the bottom of the list.

@adelloste adelloste requested a review from a team as a code owner May 15, 2024 16:50
@pagopa-github-bot pagopa-github-bot changed the title [IOPAE-1164] Fix infinite scroll in InstitutionServicesScreen fix: [IOPAE-1164] Fix infinite scroll in InstitutionServicesScreen May 15, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 15, 2024

Affected stories

  • 🐞 IOPAE-1164: [APP] Nella home ente la paginazione non funziona correttamente
    subtask of
    • IOPAE-645: Redesign sezione servizi (PNRR 31.12.2024)

Generated by 🚫 dangerJS against c343baf

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 49.54%. Comparing base (4f204b4) to head (c343baf).
Report is 79 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5774      +/-   ##
==========================================
+ Coverage   48.42%   49.54%   +1.11%     
==========================================
  Files        1488     1603     +115     
  Lines       31617    31874     +257     
  Branches     7669     7769     +100     
==========================================
+ Hits        15311    15792     +481     
+ Misses      16238    16019     -219     
+ Partials       68       63       -5     
Files Coverage Δ
...ces/institution/components/ServiceListSkeleton.tsx 100.00% <100.00%> (ø)
.../services/institution/hooks/useServicesFetcher.tsx 88.46% <82.35%> (ø)
.../institution/screens/InstitutionServicesScreen.tsx 81.63% <88.00%> (ø)

... and 419 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdca533...c343baf. Read the comment docs.

@adelloste adelloste merged commit 8760edc into master May 16, 2024
13 checks passed
@adelloste adelloste deleted the IOPAE-1164-fix-pagination branch May 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants