chore(IT Wallet): [SIW-1128] Add EidCard and EidCardPreview components
#5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastro993
changed the title
EIdCard and EIdCardPreview components
pagopa-github-bot
changed the title
EIdCard and EIdCardPreview componentsEIdCard and EIdCardPreview components
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5772 +/- ##
==========================================
+ Coverage 48.42% 49.55% +1.13%
==========================================
Files 1488 1619 +131
Lines 31617 32140 +523
Branches 7669 7724 +55
==========================================
+ Hits 15311 15928 +617
+ Misses 16238 16158 -80
+ Partials 68 54 -14
... and 497 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dmnplb
approved these changes
May 16, 2024
mastro993
changed the title
EIdCard and EIdCardPreview componentsEidCard and EidCardPreview components
mastro993
added a commit
that referenced
this pull request
May 30, 2024
> [!WARNING] > This PR depends on #5779, #5772 ## Short description This PR adds the eID preview screen with mocked data. > [!important] > The screen is missing the component that allows scrolling to the bottom of the page. There is currently an incompatibility with the `IOScrollViewWithLargeHeader` component which will be resolved in a separate PR ## List of changes proposed in this pull request - Added `ItwIssuanceEidPreviewScreen` component - Added required locales - Added mock data for eID, DC, DL and TS in `ItwMockUtils` ## How to test Navigate to **Profile > IT Wallet > eID > Select an IDP**. You should be able to see the new screen as the below preview. ## Preview https://github.com/pagopa/io-app/assets/6160324/9d30201f-9c16-4593-8c24-9dab38377389 --------- Co-authored-by: Damiano Plebani <damiano.plebani@pagopa.it> Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR introduces the
EidCardandEidCardPreviewcomponent for the IT Wallet EId credentialList of changes proposed in this pull request
EidCardcomponentEidCardPreviewcomponentHow to test
Go to Profile > Design System > Cards and scroll to the bottom of the screen. Check that the components are rendered correctly
Preview
RocketSim_Recording_iPhone_14_6.1_2024-05-16_22.02.17.mp4