Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPAE-1145] Add FeaturedInstitution and FeaturedService carousel/card layout #5771

Merged
merged 16 commits into from
May 17, 2024

Conversation

giuseppedipinto
Copy link
Contributor

@giuseppedipinto giuseppedipinto commented May 15, 2024

Short description

This PR introduce 2 new carousels: one for featured institutions and one for featured services.
These carousels will be used in new Services tab for Services Redesign work stream.

Details

featured institution/services cards
featured.mp4

List of changes proposed in this pull request

  • add new sections InstitutionCard and ServiceCard into ts/features/design-system/core/DSCards.tsx
  • add FeaturedInstitutionsCarousel that renders FeaturedInstitutionCard
  • add FeaturedInstitutionsCarouselSkeleton that renders FeaturedInstitutionCardSkeleton
  • add FeaturedServicesCarousel that renders FeaturedServiceCard
  • add FeaturedServicesCarouselSkeleton that renders FeaturedServiceCardSkeleton
  • add OrganizationNameLabel custom text needed to render organization name in FeaturedServiceCard bottom view
  • add logoForService function utility with a different function parameter sign
  • update @pagopa/io-app-design-system to 1.36.14

How to test

Check it into Design System >> Cards dev.mode section.

@giuseppedipinto giuseppedipinto requested review from dmnplb, a team and thisisjp as code owners May 15, 2024 13:31
@pagopa-github-bot pagopa-github-bot changed the title [IOPAE-1145] Add FeaturedInstitution and FeaturedService carousel/card layout chore: [IOPAE-1145] Add FeaturedInstitution and FeaturedService carousel/card layout May 15, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 15, 2024

Affected stories

  • ⚙️ IOPAE-1145: [IO-APP] Sviluppo layout card ente e card servizio in evidenza
    subtask of
    • 🌟 IOPAE-1135: [Rework] Enti & Servizi in evidenza su App IO

Generated by 🚫 dangerJS against 93ac3c1

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 48.43750% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 49.51%. Comparing base (4f204b4) to head (93ac3c1).
Report is 87 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5771      +/-   ##
==========================================
+ Coverage   48.42%   49.51%   +1.08%     
==========================================
  Files        1488     1617     +129     
  Lines       31617    32112     +495     
  Branches     7669     7821     +152     
==========================================
+ Hits        15311    15900     +589     
+ Misses      16238    16149      -89     
+ Partials       68       63       -5     
Files Coverage Δ
ts/features/design-system/core/DSCards.tsx 80.00% <100.00%> (+13.33%) ⬆️
...services/home/components/OrganizationNameLabel.tsx 75.00% <75.00%> (ø)
...rvices/home/components/FeaturedInstitutionCard.tsx 70.00% <70.00%> (ø)
ts/features/services/home/utils/index.ts 0.00% <0.00%> (ø)
...s/services/home/components/FeaturedServiceCard.tsx 50.00% <50.00%> (ø)
...s/home/components/FeaturedInstitutionsCarousel.tsx 40.00% <40.00%> (ø)
...vices/home/components/FeaturedServicesCarousel.tsx 40.00% <40.00%> (ø)

... and 487 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8befc67...93ac3c1. Read the comment docs.

Copy link
Contributor

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I checked the FeaturedInstitution block. I'll check the FeaturedService block later. In the meantime, I'd like to ask why there is a different snap scroll behavior between the two carousels. Applying the same interaction pattern to the service cards would be cool.

Copy link
Contributor

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@adelloste adelloste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppedipinto giuseppedipinto merged commit 2b85bf7 into master May 17, 2024
13 checks passed
@giuseppedipinto giuseppedipinto deleted the IOPAE-1145-featured-institution-service-cards branch May 17, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants