-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOPAE-1145] Add FeaturedInstitution and FeaturedService carousel/card layout #5771
chore: [IOPAE-1145] Add FeaturedInstitution and FeaturedService carousel/card layout #5771
Conversation
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5771 +/- ##
==========================================
+ Coverage 48.42% 49.51% +1.08%
==========================================
Files 1488 1617 +129
Lines 31617 32112 +495
Branches 7669 7821 +152
==========================================
+ Hits 15311 15900 +589
+ Misses 16238 16149 -89
+ Partials 68 63 -5
... and 487 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I checked the FeaturedInstitution
block. I'll check the FeaturedService
block later. In the meantime, I'd like to ask why there is a different snap scroll behavior between the two carousels. Applying the same interaction pattern to the service cards would be cool.
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedInstitutionCard.tsx
Outdated
Show resolved
Hide resolved
ts/features/services/home/components/FeaturedServicesCarousel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…://github.com/pagopa/io-app into IOPAE-1145-featured-institution-service-cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR introduce 2 new carousels: one for featured institutions and one for featured services.
These carousels will be used in new Services tab for Services Redesign work stream.
Details
featured.mp4
List of changes proposed in this pull request
ts/features/design-system/core/DSCards.tsx
logoForService
function utility with a different function parameter sign@pagopa/io-app-design-system
to 1.36.14How to test
Check it into
Design System >> Cards
dev.mode section.