Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPAE-1148] Add Institutions search #5769

Merged
merged 40 commits into from
May 30, 2024
Merged

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented May 14, 2024

Short description

This PR allows to search for national and local institutions.

details

search
search.mp4

List of changes proposed in this pull request

  • added the SearchScreenin order to search for national and local institutions
  • added the generic component EmptyState
  • added @shopify/flash-list package
  • updated locales

How to test

Using io-dev-api-server, Navigate to the services tab and tap the search button. Try the search and check that everything works correctly.

@pagopa-github-bot pagopa-github-bot changed the title [IOPAE-1148] Add Institution search chore: [IOPAE-1148] Add Institution search May 14, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 14, 2024

Affected stories

  • ⚙️ IOPAE-1148: [APP] Implementare lista enti nazionali/locale
    subtask of
    • 🌟 IOPAE-1037: [MVP0] Come cittadino voglio vedere il risultato della mia ricerca per ente nazionale o locale

Generated by 🚫 dangerJS against d0fda41

@adelloste adelloste changed the title chore: [IOPAE-1148] Add Institution search chore: [IOPAE-1148] Add Institutions search May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 10.65574% with 109 lines in your changes are missing coverage. Please review.

Project coverage is 49.61%. Comparing base (4f204b4) to head (d0fda41).
Report is 117 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5769      +/-   ##
==========================================
+ Coverage   48.42%   49.61%   +1.19%     
==========================================
  Files        1488     1648     +160     
  Lines       31617    32820    +1203     
  Branches     7669     7863     +194     
==========================================
+ Hits        15311    16285     +974     
- Misses      16238    16481     +243     
+ Partials       68       54      -14     
Files Coverage Δ
ts/components/BonusCard/BonusCard.tsx 96.29% <ø> (ø)
ts/features/design-system/core/DSLogos.tsx 31.03% <ø> (ø)
...es/components/MessageDetail/OrganizationHeader.tsx 88.88% <ø> (-11.12%) ⬇️
.../features/services/common/navigation/navigator.tsx 28.57% <ø> (ø)
ts/features/services/common/navigation/routes.ts 100.00% <ø> (ø)
...ices/details/components/ServiceDetailsMetadata.tsx 3.03% <ø> (ø)
...rvices/home/components/FeaturedInstitutionCard.tsx 90.00% <ø> (ø)
...tures/services/home/screens/ServicesHomeScreen.tsx 5.71% <ø> (ø)
ts/features/services/home/utils/index.ts 100.00% <ø> (ø)
.../services/institution/hooks/useServicesFetcher.tsx 73.07% <100.00%> (ø)
... and 9 more

... and 583 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02bd520...d0fda41. Read the comment docs.

locales/en/index.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppedipinto giuseppedipinto merged commit 50fa6cf into master May 30, 2024
13 checks passed
@giuseppedipinto giuseppedipinto deleted the IOPAE-1148-search branch May 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants