feat: [IOCOM-1391] Flag to enable Messages Home with the new DS #5766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5766 +/- ##
==========================================
+ Coverage 48.42% 49.54% +1.12%
==========================================
Files 1488 1604 +116
Lines 31617 31869 +252
Branches 7669 7702 +33
==========================================
+ Hits 15311 15790 +479
+ Misses 16238 16016 -222
+ Partials 68 63 -5
... and 416 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
# Conflicts: # ts/features/messages/screens/MessagesHomeScreen.tsx
Vangaorth
changed the title
Linked using the title |
LazyAfternoons
changed the title
pagopa-github-bot
changed the title
Vangaorth
added a commit
that referenced
this pull request
May 17, 2024
…sages' Home (#5770)⚠️ This PR depends on #5766⚠️ ## Short description This PR adds the Chip behaviour to the new DS Messages' Home. |Inbox|Archived| |-|-| ||| ## List of changes proposed in this pull request New Messages Home is organised as follows: ``` MessagesHome \_TabNavigationContainer \_InboxTab \_ArchivedTab \_ViewPagerContainer \_MessageList // Inbox \_MessageList // Archive ``` The major challenge is to avoid unnecessary re-renderings in the components included by the`ViewPager`. In order to do so, the shown category (inbox or archive) is stored into redux (`ts/features/messages/store/reducers/allPaginated.ts`), inside the `allPaginated` state (which is not persisted) as a literal which value can be either `inbox` or `archive`. Named `shownCategory`, its value can be retrieved using a selector (`shownMessageCategorySelector`). The `TabNavigationContainer` component uses such value in order to display the selected tab. On every change, it re-renders itself. On a press event, it dispatches an action to trigger the change into redux and it also instructs the `ViewPager` component to scroll to the desired page. This is necessary since the `ViewPager` does not have a method to show the current page based on a changing value (i.e., it needs to be done programmatically). A guard prevents the event logic to be fired if the already selected Tab is pressed. The `ViewPagerContainer` shows the Inbox and Archive message lists using the new `MessageList` component (and specialising it by assigning the proper category). Since there are only two pages, both instances of `MessageList` are rendered upon first ViewPagerContainer loading. In order to avoid unnecessary re-renderings when the user scrolls horizontally between the pages, the underlying `ViewPager` uses the `onPageSelected` event to dispatch the redux action that updates the `shownCategory`. This triggers the re-rendering of `TabNavigationContainer`, keeping the UI aligned. This event is triggered only when the page changes (i.e., there is no need for a "same-page" guard like in `TabNavigationContainer`). Finally, the logic that triggers the first message loading is placed inside the `TabNavigationContainer`, since it is the only component that can use an `useEffect` hook that triggers every time the screen changes. Loading is fired only if the related message section pot (inbox or archived) is `pot.none`. As a last note, this PR also moves legacy messages' screens and legacy messages home's components into related `legacy` folders. ## How to test Enable both new DS and new Messages' Home (from Profile). Check that: - tap on a Chip switches both Chip and View Pager - slide on the View Pager switches both View Pager and Chip - upon first full displaying of each inbox and archive screens, a `reloadAllMessage.request` should be fired (but no more afterwards) - check that the only component that re-renders itself multiple times is `TabNavigationContainer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a persisted preference to display the Messages Home with the new DS.
List of changes proposed in this pull request
isNewHomeSectionEnabledproperty onpersistedPreferences, with its migrationDeveloperModeSectioncomponent has a new switch to control such property valueTabNavigatorspawns either the Legacy or the newMessagesHomeScreenMessagesHomeScreenrenamed toLegacyMessagesHomeScreenHow to test
Using the io-dev-api-server, check that both the new and the old messages home screen is displayed, when the related toggle is changed in the debug profile options.